Re: [PATCH 0/4] esp-pci: fixes for Linux and MS-DOS

[Guenter Roeck]

On 1/20/24 05:09, Michael Tokarev wrote:
> 12.01.2024 16:15, Mark Cave-Ayland:
> > This series contains fixes for the esp-pci device (am53c974 or dc390) for a
> > few issues spotted whilst testing the previous ESP series.
> >
> > Patches 1-3 are fixes for issues found by Helge/Guenter whilst testing the
> > hppa C3700 machine with the amd53c974/dc390 devices under Linux, whilst patch
> > 4 fixes an issue that was exposed by testing MS-DOS and Windows drivers.
> >
> > With this series applied on top of the reworked ESP device, it is possible to
> > boot Linux under qemu-system-hppa without any errors and also boot and install
> > Win98SE from a DC390 PCI SCSI controller (no IDE!) using an MS-DOS boot floppy.
> >
> > Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> > Based-on: 20240112125420.514425-1-mark.cave-ayland@ilande.co.uk
> >
> >
> > Mark Cave-Ayland (4):
> >    esp-pci.c: use correct address register for PCI DMA transfers
> >    esp-pci.c: generate PCI interrupt from separate ESP and PCI sources
> >    esp-pci.c: synchronise setting of DMA_STAT_DONE with ESP completion
> >      interrupt
> >    esp-pci.c: set DMA_STAT_BCMBLT when BLAST command issued
>
> Is it worth to pick up for stable?  Especially the first one.
> It's interesting this bug is here for a very long time.. :)

FWIW, I never observed the first one with Linux. I had carried variants
of the other three in my tree for a long time, but they were never
in a shape to be sent upstream and I never bothered trying to find
the root cause. All those _can_ be observed when booting Linux. So,
if anything, I'd argue that they should all be taken into stable
releases.

Thanks,
Guenter