[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/5] migration: Reference migration state around loadvm_postcopy_
From: |
Fabiano Rosas |
Subject: |
[PATCH 3/5] migration: Reference migration state around loadvm_postcopy_handle_run_bh |
Date: |
Fri, 19 Jan 2024 20:39:20 -0300 |
We need to hold a reference to the current_migration object around
async calls to avoid it been freed while still in use. Even on this
load-side function, we might still use the MigrationState, e.g to
check for capabilities.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
migration/savevm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration/savevm.c b/migration/savevm.c
index 6410705ebe..93387350c7 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2174,6 +2174,7 @@ static void loadvm_postcopy_handle_run_bh(void *opaque)
qemu_bh_delete(mis->bh);
trace_vmstate_downtime_checkpoint("dst-postcopy-bh-vm-started");
+ object_unref(OBJECT(migration_get_current()));
}
/* After all discards we can start running and asking for pages */
@@ -2189,6 +2190,7 @@ static int
loadvm_postcopy_handle_run(MigrationIncomingState *mis)
postcopy_state_set(POSTCOPY_INCOMING_RUNNING);
mis->bh = qemu_bh_new(loadvm_postcopy_handle_run_bh, mis);
+ object_ref(OBJECT(migration_get_current()));
qemu_bh_schedule(mis->bh);
/* We need to finish reading the stream from the package
--
2.35.3
[PATCH 5/5] migration: Centralize BH creation and dispatch, Fabiano Rosas, 2024/01/19
[PATCH 4/5] migration: Add a wrapper to qemu_bh_schedule, Fabiano Rosas, 2024/01/19
Re: [PATCH 0/5] migration: Fix migration state reference counting, Peter Xu, 2024/01/22