qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/4] qemu-options: Remove the deprecated -no-acpi option


From: Michael Tokarev
Subject: Re: [PATCH v2 2/4] qemu-options: Remove the deprecated -no-acpi option
Date: Thu, 18 Jan 2024 13:44:41 +0300
User-agent: Mozilla Thunderbird

18.01.2024 13:37, Thomas Huth:
..
      /*
-     * When -no-acpi is used with Q35 machine type, no ACPI is built,
+     * When "-M acpi=off" is used with Q35 machine type, no ACPI is built,
       * but pcms->acpi_dev is still created. Check !acpi_enabled in

FWIW, it's easier to use "When acpi=off is used with Q35 machine type.."
instead, since acpi=off is a machine property and here we talk about
machine, so the context is quite clear.  Here and in the next similar
commit.  Just a nitpick, works either way for me.

Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]