[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] tests/vm/netbsd: Remove missing py311-expat package
From: |
Thomas Huth |
Subject: |
Re: [RFC PATCH] tests/vm/netbsd: Remove missing py311-expat package |
Date: |
Wed, 17 Jan 2024 13:10:37 +0100 |
User-agent: |
Mozilla Thunderbird |
On 17/01/2024 12.24, Philippe Mathieu-Daudé wrote:
Per commits a9dbde71da ("mkvenv: add better error message for
broken or missing ensurepip") and 1dee66c693 ("tests/vm: add
py310-expat to NetBSD"), we need py-expat to use ensurepip.
However the py311-expat package isn't available anymore:
### Installing packages ...
processing remote summary
(http://cdn.NetBSD.org/pub/pkgsrc/packages/NetBSD/amd64/9.3/All)...
database for http://cdn.NetBSD.org/pub/pkgsrc/packages/NetBSD/amd64/9.3/All
is up-to-date
py311-expat is not available in the repository
...
calculating dependencies.../py311-expat is not available in the repository
pkg_install error log can be found in /var/db/pkgin/pkg_install-err.log
Dropping it from the default packages list allows creating the
NetBSD VM and build / test QEMU, without error from ensurepip.
This reverts commit 1dee66c693 ("tests/vm: add py310-expat to NetBSD").
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2109
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
RFC because ensurepip seems important due to cited commits
but I'm not sure where it is used, and this fixes my CI build.
Thanks for tackling it, I also ran into this problem already and just did
not have enough spare time yet to investigate.
I searched a little bit, and found this text here:
https://mail-index.netbsd.org/netbsd-announce/2024/01/01/msg000360.html
"
- Several packages have been folded into base packages. While the
result is simpler, those updating may need to force-remove the
secondary packages, depending on the update method. When doing
make replace, one has to pkg_delete -f the secondary packages.
pkgin handles at least the python packages correctly, removing the
split package when updating python. Specific packages and the
former packages now included:
* cairo: cairo-gobject
* python: py-cElementTree py-curses py-cursespanel py-expat
py-readline py-sqlite3
"
So it seems like the py-expat package has simply been merged into a base
package now. Thus I think your patch is fine. It also fixes the problem for
me, so:
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>