[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/20] tests/qtest: Re-enable multifd cancel test
From: |
peterx |
Subject: |
[PULL 09/20] tests/qtest: Re-enable multifd cancel test |
Date: |
Tue, 16 Jan 2024 11:19:36 +0800 |
From: Fabiano Rosas <farosas@suse.de>
We've found the source of flakiness in this test, so re-enable it.
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20230606144551.24367-4-farosas@suse.de
[peterx: rebase to 2a61a6964c, to use migration_test_add()]
Signed-off-by: Peter Xu <peterx@redhat.com>
---
tests/qtest/migration-test.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 21da140aea..d3066e119f 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -3550,14 +3550,8 @@ int main(int argc, char **argv)
}
migration_test_add("/migration/multifd/tcp/plain/none",
test_multifd_tcp_none);
- /*
- * This test is flaky and sometimes fails in CI and otherwise:
- * don't run unless user opts in via environment variable.
- */
- if (getenv("QEMU_TEST_FLAKY_TESTS")) {
- migration_test_add("/migration/multifd/tcp/plain/cancel",
- test_multifd_tcp_cancel);
- }
+ migration_test_add("/migration/multifd/tcp/plain/cancel",
+ test_multifd_tcp_cancel);
migration_test_add("/migration/multifd/tcp/plain/zlib",
test_multifd_tcp_zlib);
#ifdef CONFIG_ZSTD
--
2.43.0
- [PULL 00/20] Migration 20240116 patches, peterx, 2024/01/15
- [PULL 01/20] migration: Simplify initial conditionals in migration for better readability, peterx, 2024/01/15
- [PULL 02/20] migration/multifd: Remove MultiFDPages_t::packet_num, peterx, 2024/01/15
- [PULL 04/20] migration/multifd: Change multifd_pages_init argument, peterx, 2024/01/15
- [PULL 09/20] tests/qtest: Re-enable multifd cancel test,
peterx <=
- [PULL 03/20] migration/multifd: Remove QEMUFile from where it is not needed, peterx, 2024/01/15
- [PULL 06/20] tests/qtest/migration: Print migration incoming errors, peterx, 2024/01/15
- [PULL 07/20] tests/qtest/migration: Add a wrapper to print test names, peterx, 2024/01/15
- [PULL 08/20] tests/qtest/migration: Use the new migration_test_add, peterx, 2024/01/15
- [PULL 10/20] docs/migration: Create migration/ directory, peterx, 2024/01/15
- [PULL 11/20] docs/migration: Create index page, peterx, 2024/01/15
- [PULL 12/20] docs/migration: Convert virtio.txt into rST, peterx, 2024/01/15
- [PULL 14/20] docs/migration: Split "Debugging" and "Firmware", peterx, 2024/01/15
- [PULL 13/20] docs/migration: Split "Backwards compatibility" separately, peterx, 2024/01/15
- [PULL 15/20] docs/migration: Split "Postcopy", peterx, 2024/01/15