Re: [PATCH v12 04/10] hw/net: Add NPCMXXX GMAC device

[Peter Maydell]

On Wed, 10 Jan 2024 at 23:42, Nabih Estefan <nabihestefan@google.com> wrote:
>
> From: Hao Wu <wuhaotsh@google.com>
>
> This patch implements the basic registers of GMAC device and sets
> registers for networking functionalities.
>
> Tested:
> The following message shows up with the change:
> Broadcom BCM54612E stmmac-0:00: attached PHY driver [Broadcom BCM54612E] 
> (mii_bus:phy_addr=stmmac-0:00, irq=POLL)
> stmmaceth f0802000.eth eth0: Link is Up - 1Gbps/Full - flow control rx/tx
>
> Change-Id: If71c6d486b95edcccba109ba454870714d7e0940
> Signed-off-by: Hao Wu <wuhaotsh@google.com>
> Signed-off-by: Nabih Estefan Diaz <nabihestefan@google.com>
> Reviewed-by: Tyrone Ting <kfting@nuvoton.com>
> ---

This patch doesn't compile at this point in the series, because:

> +static void npcm_gmac_write(void *opaque, hwaddr offset,
> +                              uint64_t v, unsigned size)
> +{
> +    NPCMGMACState *gmac = opaque;

...

> +
> +    gmac_update_irq(gmac);

the function gmac_update_irq() isn't defined until
later in the series.

The easy fix is to squash "include/hw/net: General GMAC Implementation"
(which incidentally still has a commit message subject that
doesn't match its contents) into this one, since it's
not very large.

-- PMM