[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v3 04/30] io: fsync before closing a file channel
|
From: |
Peter Xu |
|
Subject: |
Re: [RFC PATCH v3 04/30] io: fsync before closing a file channel |
|
Date: |
Thu, 11 Jan 2024 16:44:30 +0800 |
On Mon, Nov 27, 2023 at 05:25:46PM -0300, Fabiano Rosas wrote:
> Make sure the data is flushed to disk before closing file
> channels. This will ensure data is on disk at the end of a migration
> to file.
Looks reasonable, but just two (possibly naive) questions:
(1) Does this apply to all io channel users, or only migration?
(2) Why metadata doesn't matter (v.s. fsync(), when CONFIG_FDATASYNC=y)?
Thanks,
--
Peter Xu