Re: [PATCH v4 8/9b] target/loongarch: Implement set vcpu intr for kvm

[Philippe Mathieu-Daudé]

On 11/1/24 03:29, gaosong wrote:
> Hi,
>
> 在 2024/1/10 下午5:41, Philippe Mathieu-Daudé 写道:
> > From: Tianrui Zhao <zhaotianrui@loongson.cn>
> >
> > Implement loongarch kvm set vcpu interrupt interface,
> > when a irq is set in vcpu, we use the KVM_INTERRUPT
> > ioctl to set intr into kvm.
> >
> > Signed-off-by: Tianrui Zhao <zhaotianrui@loongson.cn>
> > Signed-off-by: xianglai li <lixianglai@loongson.cn>
> > Reviewed-by: Song Gao <gaosong@loongson.cn>
> > Message-ID: <20240105075804.1228596-9-zhaotianrui@loongson.cn>
> > [PMD: Split from bigger patch, part 2]
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   target/loongarch/kvm/kvm_loongarch.h | 16 ++++++++++++++++
> >   target/loongarch/cpu.c               |  9 ++++++++-
> >   target/loongarch/kvm/kvm.c           | 15 +++++++++++++++
> >   target/loongarch/trace-events        |  1 +
> >   4 files changed, 40 insertions(+), 1 deletion(-)
> >   create mode 100644 target/loongarch/kvm/kvm_loongarch.h


> > diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c
> > index d9f8661cfd..d3a8a2f521 100644
> > --- a/target/loongarch/cpu.c
> > +++ b/target/loongarch/cpu.c
> > @@ -12,6 +12,7 @@
> >   #include "qemu/module.h"
> >   #include "sysemu/qtest.h"
> >   #include "sysemu/tcg.h"
> > +#include "sysemu/kvm.h"
> >   #include "exec/exec-all.h"
> >   #include "cpu.h"
> >   #include "internals.h"
> > @@ -21,6 +22,10 @@
> >   #include "sysemu/reset.h"
> >   #endif
> >   #include "vec.h"
> > +#ifdef CONFIG_KVM
> > +#include "kvm/kvm_loongarch.h"
>
> This broken  tcg 'loongarch64-softmmu' build on X86 host, :-[
>
> ../target/loongarch/cpu.c: In function ‘loongarch_cpu_set_irq’:
> ../target/loongarch/cpu.c:122:9: error: implicit declaration of function 
> ‘kvm_loongarch_set_interrupt’ [-Werror=implicit-function-declaration]
>    122 |         kvm_loongarch_set_interrupt(cpu, irq, level);
>        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../target/loongarch/cpu.c:122:9: error: nested extern declaration of 
> ‘kvm_loongarch_set_interrupt’ [-Werror=nested-externs]
> ../target/loongarch/cpu.c: In function ‘loongarch_cpu_reset_hold’:
> ../target/loongarch/cpu.c:557:9: error: implicit declaration of function 
> ‘kvm_arch_reset_vcpu’; did you mean ‘kvm_arch_init_vcpu’? 
> [-Werror=implicit-function-declaration]
>    557 |         kvm_arch_reset_vcpu(env);
>        |         ^~~~~~~~~~~~~~~~~~~
>        |         kvm_arch_init_vcpu
> ../target/loongarch/cpu.c:557:9: error: nested extern declaration of 
> ‘kvm_arch_reset_vcpu’ [-Werror=nested-externs]
> cc1: all warnings being treated as errors
>
> I will move it out of  '#ifdef CONFIG_KVM'

Oh, right.

(Sorry I only tested on loongarch64 host).

Thanks!

Phil.