Re: [PATCH for 8.2.1] hw/net: cadence_gem: Fix MDIO_OP_xxx values

[Philippe Mathieu-Daudé]

On 2/1/24 19:32, Heinrich Schuchardt wrote:
> On 1/2/24 16:08, Philippe Mathieu-Daudé wrote:
> > On 2/1/24 15:18, Bin Meng wrote:
> > > Testing upstream U-Boot with 'sifive_u' machine we see:
> > >
> > >    => dhcp
> > >    ethernet@10090000: PHY present at 0
> > >    Could not get PHY for ethernet@10090000: addr 0
> > >    phy_connect failed
> > >
> > > This has been working till QEMU 8.1 but broken since QEMU 8.2.
> >
> > s/till/until/?
>
> These are synonyms. Till is more informal. No need to change.

Not obvious for non-native/fluent informal English speakers.

> > > Fixes: 1b09eeb122aa ("hw/net/cadence_gem: use FIELD to describe
> > > PHYMNTNC register fields")
> > > Reported-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > > Signed-off-by: Bin Meng <bmeng@tinylab.org>
> > >
> > > ---
> > >
> > >   hw/net/cadence_gem.c | 4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)