[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 16/16] replay: report sync error when no exception in log (!DE
From: |
Alex Bennée |
Subject: |
[PATCH v2 16/16] replay: report sync error when no exception in log (!DEBUG INVESTIGATION) |
Date: |
Mon, 11 Dec 2023 09:13:45 +0000 |
If replay_exception returns false we can only trigger an exit from the
main loop and hope something unwinds to something we can process. This
seems to be the point where execution diverges in the replay_linux
tests case.
DISCUSSION: Maybe this should be tightened up to check the remaining
instruction count?
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
replay/replay.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/replay/replay.c b/replay/replay.c
index 665dbb34fb..d283c1353d 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -209,11 +209,12 @@ bool replay_exception(void)
return true;
} else if (replay_mode == REPLAY_MODE_PLAY) {
g_assert(replay_mutex_locked());
- bool res = replay_has_exception();
- if (res) {
+ if (replay_has_exception()) {
replay_finish_event();
+ return true;
+ } else {
+ replay_sync_error("Exception not in log");
}
- return res;
}
return true;
--
2.39.2
- Re: [PATCH v2 10/16] replay/replay-char: use report_sync_error, (continued)
- [PATCH v2 08/16] replay: make has_unread_data a bool, Alex Bennée, 2023/12/11
- [PATCH v2 11/16] replay: stop us hanging in rr_wait_io_event, Alex Bennée, 2023/12/11
- [PATCH v2 14/16] accel/tcg: define tlb_fill as a trace point, Alex Bennée, 2023/12/11
- [PATCH v2 15/16] accel/tcg: add trace_tlb_resize trace point, Alex Bennée, 2023/12/11
- [PATCH v2 16/16] replay: report sync error when no exception in log (!DEBUG INVESTIGATION),
Alex Bennée <=
- [PATCH v2 13/16] tests/avocado: remove skips from replay_kernel, Alex Bennée, 2023/12/11
- [PATCH v2 12/16] chardev: force write all when recording replay logs, Alex Bennée, 2023/12/11
- Re: [PATCH v2 00/16] record/replay fixes: attempting to get avocado green, Alex Bennée, 2023/12/13