qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses


From: Patrick Venture
Subject: Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses
Date: Wed, 15 Nov 2023 08:58:29 -0800



On Wed, Nov 15, 2023 at 2:35 AM Peter Maydell <peter.maydell@linaro.org> wrote:
On Tue, 14 Nov 2023 at 20:55, Patrick Venture <venture@google.com> wrote:
> Avoids unaligned pointer issues.
>

It would be nice to be more specific in the commit message here, by
describing what kind of guest behaviour or machine config runs into this
problem, and whether this happens in a situation users are likely to
run into. If the latter, we should consider tagging the commit
with "Cc: qemu-stable@nongnu.org" to have it backported to the
stable release branches.

Thanks! I'll update the commit message with v2.  We were seeing this in our infrastructure with unaligned accesses using the pointer dereference as there are no guarantees on alignment of the incoming values.
 

thanks
-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]