Re: [PATCH 6/8] docs/specs/virt-ctlr: Convert to rST

[Philippe Mathieu-Daudé]

On 31/10/23 16:43, Peter Maydell wrote:
> On Tue, 31 Oct 2023 at 15:39, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> > On 27/9/23 17:12, Peter Maydell wrote:
> > > Convert docs/specs/virt-ctlr.txt to rST format.
> > >
> > > I added the name of the device to give readers a bit more idea
> > > of which device we're actually documenting here.
> > >
> > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > > ---
> > >    docs/specs/index.rst                        |  1 +
> > >    docs/specs/{virt-ctlr.txt => virt-ctlr.rst} | 12 +++++-------
> > >    2 files changed, 6 insertions(+), 7 deletions(-)
> > >    rename docs/specs/{virt-ctlr.txt => virt-ctlr.rst} (70%)
> >
> >
> > $ ./scripts/get_maintainer.pl -f docs/specs/virt-ctlr.txt
> > get_maintainer.pl: No maintainers found, printing recent contributors.
> > get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.
> >
> > $ ./scripts/get_maintainer.pl -f hw/misc/virt_ctrl.c
> > Laurent Vivier <laurent@vivier.eu> (maintainer:virt)
> > qemu-devel@nongnu.org (open list:All patches CC here)
> >
> > Cc'ing Laurent.
>
> That raises the question, is it intentional that the doc
> is virt-ctlr but the source file is virt-ctrl ? Should we
> rename one of them (looks like the doc, so easy enough to
> do as part of this patch)?

$ git grep ctlr| wc -l
     430
$ git grep ctrl| wc -l
    4063

Since you are already renaming the file, correcting the typo
in the same file seems like a good idea.