Re: [PATCH 18/24] blkverify: Add locking for request_fn

[Eric Blake]

On Fri, Oct 27, 2023 at 05:53:27PM +0200, Kevin Wolf wrote:
> This is either bdrv_co_preadv() or bdrv_co_pwritev() which both need to
> have the graph locked. Annotate the function pointer accordingly and add
> locking to its callers.
> 
> This shouldn't actually have resulted in a bug because the graph lock is
> already held by blkverify_co_prwv(), which waits for the coroutines to
> terminate. Annotate with GRAPH_RDLOCK as well to make this clearer.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/blkverify.c | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org