[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 10/12] migration: Use migration_transferred_bytes()
From: |
Juan Quintela |
Subject: |
[PATCH v2 10/12] migration: Use migration_transferred_bytes() |
Date: |
Wed, 25 Oct 2023 11:11:15 +0200 |
There are only two differnces with the old value:
- the amount of QEMUFile that hasn't yet been flushed. It can be
discussed what is more exact, the new or the old one.
- the amount of transferred bytes that we forgot to account for (the
newer is better, i.e. exact).
Notice that this two values are used to:
a - present to the user
b - calculate the rate_limit
So a few KB here and there is not going to make a difference.
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
migration/migration.c | 2 +-
migration/ram.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index bb62244288..a6cde985a2 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -942,7 +942,7 @@ static void populate_ram_info(MigrationInfo *info,
MigrationState *s)
size_t page_size = qemu_target_page_size();
info->ram = g_malloc0(sizeof(*info->ram));
- info->ram->transferred = stat64_get(&mig_stats.transferred);
+ info->ram->transferred = migration_transferred_bytes();
info->ram->total = ram_bytes_total();
info->ram->duplicate = stat64_get(&mig_stats.zero_pages);
/* legacy value. It is not used anymore */
diff --git a/migration/ram.c b/migration/ram.c
index 92769902bb..5ccf70333a 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -564,7 +564,7 @@ void mig_throttle_counter_reset(void)
rs->time_last_bitmap_sync = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
rs->num_dirty_pages_period = 0;
- rs->bytes_xfer_prev = stat64_get(&mig_stats.transferred);
+ rs->bytes_xfer_prev = migration_transferred_bytes();
}
/**
@@ -1030,7 +1030,7 @@ static void migration_trigger_throttle(RAMState *rs)
{
uint64_t threshold = migrate_throttle_trigger_threshold();
uint64_t bytes_xfer_period =
- stat64_get(&mig_stats.transferred) - rs->bytes_xfer_prev;
+ migration_transferred_bytes() - rs->bytes_xfer_prev;
uint64_t bytes_dirty_period = rs->num_dirty_pages_period *
TARGET_PAGE_SIZE;
uint64_t bytes_dirty_threshold = bytes_xfer_period * threshold / 100;
@@ -1100,7 +1100,7 @@ static void migration_bitmap_sync(RAMState *rs, bool
last_stage)
/* reset period counters */
rs->time_last_bitmap_sync = end_time;
rs->num_dirty_pages_period = 0;
- rs->bytes_xfer_prev = stat64_get(&mig_stats.transferred);
+ rs->bytes_xfer_prev = migration_transferred_bytes();
}
if (migrate_events()) {
uint64_t generation = stat64_get(&mig_stats.dirty_sync_count);
--
2.41.0
- [PATCH v2 00/12] migration: Yet another round of atomic counters, Juan Quintela, 2023/10/25
- [PATCH v2 02/12] qemu_file: Use a stat64 for qemu_file_transferred, Juan Quintela, 2023/10/25
- [PATCH v2 05/12] qemu_file: Remove unused qemu_file_transferred(), Juan Quintela, 2023/10/25
- [PATCH v2 06/12] qemu-file: Remove _noflush from qemu_file_transferred_noflush(), Juan Quintela, 2023/10/25
- [PATCH v2 01/12] qemu-file: Don't increment qemu_file_transferred at qemu_file_fill_buffer, Juan Quintela, 2023/10/25
- [PATCH v2 07/12] migration: migration_transferred_bytes() don't need the QEMUFile, Juan Quintela, 2023/10/25
- [PATCH v2 08/12] migration: migration_rate_limit_reset() don't need the QEMUFile, Juan Quintela, 2023/10/25
- [PATCH v2 10/12] migration: Use migration_transferred_bytes(),
Juan Quintela <=
- [PATCH v2 11/12] migration: Remove transferred atomic counter, Juan Quintela, 2023/10/25
- [PATCH v2 09/12] qemu-file: Simplify qemu_file_get_error(), Juan Quintela, 2023/10/25
- [PATCH v2 04/12] migration: Use the number of transferred bytes directly, Juan Quintela, 2023/10/25
- [PATCH v2 03/12] qemu_file: total_transferred is not used anymore, Juan Quintela, 2023/10/25
- [PATCH v2 12/12] qemu-file: Make qemu_fflush() return errors, Juan Quintela, 2023/10/25