Re: [PATCH 11/12] migration: Remove transferred atomic counter

[Fabiano Rosas]

Juan Quintela <quintela@redhat.com> writes:

> After last commit, it is a write only variable.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  migration/migration-stats.h | 4 ----
>  migration/multifd.c         | 3 ---
>  migration/ram.c             | 1 -
>  3 files changed, 8 deletions(-)
>
> diff --git a/migration/migration-stats.h b/migration/migration-stats.h
> index 68f3939188..05290ade76 100644
> --- a/migration/migration-stats.h
> +++ b/migration/migration-stats.h
> @@ -97,10 +97,6 @@ typedef struct {
>       * Number of bytes sent through RDMA.
>       */
>      Stat64 rdma_bytes;
> -    /*
> -     * Total number of bytes transferred.
> -     */
> -    Stat64 transferred;
>      /*
>       * Number of pages transferred that were full of zeros.
>       */
> diff --git a/migration/multifd.c b/migration/multifd.c
> index e2a45c667a..ec58c58082 100644
> --- a/migration/multifd.c
> +++ b/migration/multifd.c
> @@ -188,7 +188,6 @@ static int multifd_send_initial_packet(MultiFDSendParams 
> *p, Error **errp)
>          return -1;
>      }
>      stat64_add(&mig_stats.multifd_bytes, size);
> -    stat64_add(&mig_stats.transferred, size);
>      return 0;
>  }
>  
> @@ -733,8 +732,6 @@ static void *multifd_send_thread(void *opaque)
>  
>              stat64_add(&mig_stats.multifd_bytes,
>                         p->next_packet_size + p->packet_len);
> -            stat64_add(&mig_stats.transferred,
> -                       p->next_packet_size + p->packet_len);
>              p->next_packet_size = 0;
>              qemu_mutex_lock(&p->mutex);
>              p->pending_job--;
> diff --git a/migration/ram.c b/migration/ram.c
> index 5ccf70333a..6d2bf50614 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -455,7 +455,6 @@ void ram_transferred_add(uint64_t bytes)
>      } else {
>          stat64_add(&mig_stats.downtime_bytes, bytes);
>      }
> -    stat64_add(&mig_stats.transferred, bytes);
>  }
>  
>  struct MigrationOps {

Reviewed-by: Fabiano Rosas <farosas@suse.de>