[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/9] net/slirp: use different IDs for each instance
From: |
Juan Quintela |
Subject: |
Re: [PATCH v2 3/9] net/slirp: use different IDs for each instance |
Date: |
Tue, 24 Oct 2023 11:26:08 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) |
marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Using always 0, QEMU will end up loading the same instance, even if
> multiple have been saved.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Similar (but different) fix on next Migration PULL request.
Later, Juan.
> ---
> net/slirp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/slirp.c b/net/slirp.c
> index c33b3e02e7..af1451b60f 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -47,6 +47,7 @@
> #include "util.h"
> #include "migration/register.h"
> #include "migration/qemu-file-types.h"
> +#include "migration/vmstate.h"
>
> static int get_str_sep(char *buf, int buf_size, const char **pp, int sep)
> {
> @@ -659,7 +660,7 @@ static int net_slirp_init(NetClientState *peer, const
> char *model,
> * specific version?
> */
> g_assert(slirp_state_version() == 4);
> - register_savevm_live("slirp", 0, slirp_state_version(),
> + register_savevm_live("slirp", VMSTATE_INSTANCE_ID_ANY,
> slirp_state_version(),
> &savevm_slirp_state, s->slirp);
>
> s->poll_notifier.notify = net_slirp_poll_notify;
- [PATCH v2 0/9] RFC: migration: check required entries and sections are loaded, marcandre . lureau, 2023/10/24
- [PATCH v2 1/9] block/fdc: 'phase' is not needed on load, marcandre . lureau, 2023/10/24
- [PATCH v2 2/9] virtio: make endian_needed() work during loading, marcandre . lureau, 2023/10/24
- [PATCH v2 4/9] migration: rename vmstate_save_needed->vmstate_section_needed, marcandre . lureau, 2023/10/24
- [PATCH v2 3/9] net/slirp: use different IDs for each instance, marcandre . lureau, 2023/10/24
- Re: [PATCH v2 3/9] net/slirp: use different IDs for each instance,
Juan Quintela <=
- [PATCH v2 6/9] migration: check required entries are loaded, once, marcandre . lureau, 2023/10/24
- [PATCH v2 5/9] migration: check required subsections are loaded, once, marcandre . lureau, 2023/10/24
- [PATCH v2 8/9] test-vmstate: add some subsection tests, marcandre . lureau, 2023/10/24
- [PATCH v2 7/9] migration: set file error on subsection loading, marcandre . lureau, 2023/10/24
- [PATCH v2 9/9] docs/migration: reflect the changes about needed subsections, marcandre . lureau, 2023/10/24