[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/11] migration: Give one error if trying to set COMPRESS
From: |
Fabiano Rosas |
Subject: |
Re: [PATCH v2 02/11] migration: Give one error if trying to set COMPRESSION and XBZRLE |
Date: |
Mon, 23 Oct 2023 10:32:36 -0300 |
Juan Quintela <quintela@redhat.com> writes:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> migration/options.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/migration/options.c b/migration/options.c
> index b8c3c3218d..37fa1cfe74 100644
> --- a/migration/options.c
> +++ b/migration/options.c
> @@ -625,6 +625,13 @@ bool migrate_caps_check(bool *old_caps, bool *new_caps,
> Error **errp)
> }
> }
>
> + if (new_caps[MIGRATION_CAPABILITY_COMPRESS]) {
> + if (new_caps[MIGRATION_CAPABILITY_XBZRLE]) {
> + error_setg(errp, "Compression is not compatible with xbzrle");
> + return false;
> + }
> + }
> +
> return true;
> }
Reviewed-by: Fabiano Rosas <farosas@suse.de>
- [PATCH v2 00/11] Migration compression cleanup, Juan Quintela, 2023/10/19
- [PATCH v2 01/11] migration: Give one error if trying to set MULTIFD and XBZRLE, Juan Quintela, 2023/10/19
- [PATCH v2 03/11] migration: Remove save_page_use_compression(), Juan Quintela, 2023/10/19
- [PATCH v2 05/11] migration: Simplify compress_page_with_multithread(), Juan Quintela, 2023/10/19
- [PATCH v2 02/11] migration: Give one error if trying to set COMPRESSION and XBZRLE, Juan Quintela, 2023/10/19
- Re: [PATCH v2 02/11] migration: Give one error if trying to set COMPRESSION and XBZRLE,
Fabiano Rosas <=
- [PATCH v2 06/11] migration: Move busy++ to migrate_with_multithread, Juan Quintela, 2023/10/19
- [PATCH v2 11/11] migration: Rename ram_compressed_pages() to compress_ram_pages(), Juan Quintela, 2023/10/19
- [PATCH v2 08/11] migration: Export send_queued_data(), Juan Quintela, 2023/10/19
- [PATCH v2 07/11] migration: Create compress_update_rates(), Juan Quintela, 2023/10/19
- [PATCH v2 10/11] migration: Merge flush_compressed_data() and compress_flush_data(), Juan Quintela, 2023/10/19