Re: [PATCH v2 00/16] tests: Add CPU topology related smbios test cases

[Michael S. Tsirkin]

On Thu, Sep 28, 2023 at 08:59:27PM +0800, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> Hi all,
> 
> This patchset is the v2 which adds more description about the topology
> selection under Igor's comments.


I dropped this due to CI failures.

> In this patchset, add these test cases:
> 
> 1. Add the case to test 2 newly added topology helpers (patch 1):
>    * machine_topo_get_cores_per_socket()
>    * machine_topo_get_threads_per_socket()
> 
> 2. Add the cases in bios-tables-test.c to:
>    * test smbios type4 table count (patch 2-4).
>    * test smbios type4 core count field (patch 5-7).
>    * update the test of smbios type4 core count2 field (patch 8-10).
>    * test smbios type4 thread count (patch 11-13).
>    * test smbios type4 thread count2 (patch 14-16).
> 
> With the above new cases, cover all commits of [1] in test.
> 
> v1: https://lists.gnu.org/archive/html/qemu-devel/2023-08/msg04420.html
> 
> [1]: https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg06225.html
> 
> Regards,
> Zhao
> ---
> Zhao Liu (16):
>   tests: test-smp-parse: Add the test for cores/threads per socket
>     helpers
>   tests: bios-tables-test: Prepare the ACPI table change for smbios
>     type4 count test
>   tests: bios-tables-test: Add test for smbios type4 count
>   tests: bios-tables-test: Add ACPI table binaries for smbios type4
>     count test
>   tests: bios-tables-test: Prepare the ACPI table change for smbios
>     type4 core count test
>   tests: bios-tables-test: Add test for smbios type4 core count
>   tests: bios-tables-test: Add ACPI table binaries for smbios type4 core
>     count test
>   tests: bios-tables-test: Prepare the ACPI table change for smbios
>     type4 core count2 test
>   tests: bios-tables-test: Extend smbios core count2 test to cover
>     general topology
>   tests: bios-tables-test: Update ACPI table binaries for smbios core
>     count2 test
>   tests: bios-tables-test: Prepare the ACPI table change for smbios
>     type4 thread count test
>   tests: bios-tables-test: Add test for smbios type4 thread count
>   tests: bios-tables-test: Add ACPI table binaries for smbios type4
>     thread count test
>   tests: bios-tables-test: Prepare the ACPI table change for smbios
>     type4 thread count2 test
>   tests: bios-tables-test: Add test for smbios type4 thread count2
>   tests: bios-tables-test: Add ACPI table binaries for smbios type4
>     thread count2 test
> 
>  tests/data/acpi/q35/APIC.core-count    | Bin 0 -> 544 bytes
>  tests/data/acpi/q35/APIC.core-count2   | Bin 2478 -> 3238 bytes
>  tests/data/acpi/q35/APIC.thread-count  | Bin 0 -> 544 bytes
>  tests/data/acpi/q35/APIC.thread-count2 | Bin 0 -> 7398 bytes
>  tests/data/acpi/q35/APIC.type4-count   | Bin 0 -> 1072 bytes
>  tests/data/acpi/q35/DSDT.core-count    | Bin 0 -> 12913 bytes
>  tests/data/acpi/q35/DSDT.core-count2   | Bin 32495 -> 33770 bytes
>  tests/data/acpi/q35/DSDT.thread-count  | Bin 0 -> 12913 bytes
>  tests/data/acpi/q35/DSDT.thread-count2 | Bin 0 -> 63671 bytes
>  tests/data/acpi/q35/DSDT.type4-count   | Bin 0 -> 18589 bytes
>  tests/data/acpi/q35/FACP.core-count    | Bin 0 -> 244 bytes
>  tests/data/acpi/q35/FACP.thread-count  | Bin 0 -> 244 bytes
>  tests/data/acpi/q35/FACP.thread-count2 | Bin 0 -> 244 bytes
>  tests/data/acpi/q35/FACP.type4-count   | Bin 0 -> 244 bytes
>  tests/qtest/bios-tables-test.c         | 116 ++++++++++++++++++++++++-
>  tests/unit/test-smp-parse.c            |  67 +++++++++++---
>  16 files changed, 167 insertions(+), 16 deletions(-)
>  create mode 100644 tests/data/acpi/q35/APIC.core-count
>  create mode 100644 tests/data/acpi/q35/APIC.thread-count
>  create mode 100644 tests/data/acpi/q35/APIC.thread-count2
>  create mode 100644 tests/data/acpi/q35/APIC.type4-count
>  create mode 100644 tests/data/acpi/q35/DSDT.core-count
>  create mode 100644 tests/data/acpi/q35/DSDT.thread-count
>  create mode 100644 tests/data/acpi/q35/DSDT.thread-count2
>  create mode 100644 tests/data/acpi/q35/DSDT.type4-count
>  create mode 100644 tests/data/acpi/q35/FACP.core-count
>  create mode 100644 tests/data/acpi/q35/FACP.thread-count
>  create mode 100644 tests/data/acpi/q35/FACP.thread-count2
>  create mode 100644 tests/data/acpi/q35/FACP.type4-count
> 
> -- 
> 2.34.1