Re: [PATCH v13 00/10] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration

[Fabiano Rosas]

Het Gala <het.gala@nutanix.com> writes:

> On 18/10/23 7:58 pm, Fabiano Rosas wrote:
>> Het Gala <het.gala@nutanix.com> writes:
>>
>>> Fabiano, would your below commits impact this patchset 'make check'
>>> tests ? Because you have added tests for file based migration, which is
>>> still not included in this patchset.
>> AFAICS, the tests shouldn't break.
>>
> I tried two builds to run on Qemu CI/CD pipeline,
>
> Build without those two commits which involved file based migration - 
> https://gitlab.com/galahet/Qemu/-/pipelines/1041554569
>
> Build with those two commits and only 2 patch of the current patchset - 
> https://gitlab.com/galahet/Qemu/-/pipelines/1041215154
>
> I am not 100% certain but because the 'qtest/migration-test' test 
> failed, I was of the view that might be because of those two commits.

I just sent a series on top of this one containing the additions for the
file transport support. Let's move the discussion there.