[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/14] linux-user: Exit not abort in die_with_backtrace
From: |
Richard Henderson |
Subject: |
[PULL 07/14] linux-user: Exit not abort in die_with_backtrace |
Date: |
Wed, 18 Oct 2023 16:31:27 -0700 |
This line is supposed to be unreachable, but if we're going to
have it at all, SIGABRT via abort() is subject to the same signal
peril that created this function in the first place.
We can _exit immediately without peril.
Acked-by: Helge Deller <deller@gmx.de>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/signal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index b7a2c47837..84a56b76cc 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -713,7 +713,7 @@ void die_with_signal(int host_sig)
sigsuspend(&act.sa_mask);
/* unreachable */
- abort();
+ _exit(EXIT_FAILURE);
}
static G_NORETURN
--
2.34.1
- [PULL 00/14] linux-user patch queue, Richard Henderson, 2023/10/18
- [PULL 01/14] linux-user: Fixes for zero_bss, Richard Henderson, 2023/10/18
- [PULL 02/14] linux-user/mips: fix abort on integer overflow, Richard Henderson, 2023/10/18
- [PULL 03/14] linux-user/sh4: Fix crashes on signal delivery, Richard Henderson, 2023/10/18
- [PULL 04/14] linux-user/elfload: Enable LSX/LASX in HWCAP for LoongArch, Richard Henderson, 2023/10/18
- [PULL 07/14] linux-user: Exit not abort in die_with_backtrace,
Richard Henderson <=
- [PULL 08/14] linux-user: Detect and report host crashes, Richard Henderson, 2023/10/18
- [PULL 09/14] linux-user: Only register handlers for core_dump_signal by default, Richard Henderson, 2023/10/18
- [PULL 05/14] linux-user: Propagate failure in mmap_reserve_or_unmap back to target_munmap, Richard Henderson, 2023/10/18
- [PULL 06/14] linux-user: Split out die_with_signal, Richard Henderson, 2023/10/18
- [PULL 10/14] linux-user: Map unsupported signals to an out-of-bounds value, Richard Henderson, 2023/10/18
- [PULL 11/14] linux-user: Simplify signal_init, Richard Henderson, 2023/10/18
- [PULL 13/14] linux-user: Detect and report host SIGILL, SIGFPE, SIGTRAP, Richard Henderson, 2023/10/18
- [PULL 14/14] linux-user: Remap guest SIGABRT, Richard Henderson, 2023/10/18
- [PULL 12/14] linux-user: Split out host_sig{segv,bus}_handler, Richard Henderson, 2023/10/18
- Re: [PULL 00/14] linux-user patch queue, Stefan Hajnoczi, 2023/10/20