Re: [PATCH 01/18] target/i386: group common checks in the decoding phase

[Richard Henderson]

On 10/14/23 03:01, Paolo Bonzini wrote:
> @@ -224,6 +233,8 @@ struct X86OpEntry {
>       unsigned     vex_class:8;
>       X86VEXSpecial vex_special:8;
>       uint16_t     valid_prefix:16;
> +    uint8_t      check:8;
> +    uint8_t      intercept:8;
>       bool         is_decode:1;
>   };

Unless you have a good reason otherwise, use "unsigned" with bit fields. In this case, 
'uint8_t' is really 'unsigned char', and so gdb will print the ascii by defailt.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~