[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 3/5] migration: migrate 'blk' command option is deprecated
From: |
Juan Quintela |
Subject: |
Re: [PATCH v6 3/5] migration: migrate 'blk' command option is deprecated. |
Date: |
Tue, 17 Oct 2023 22:54:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) |
Juan Quintela <quintela@redhat.com> wrote:
> Use blocked-mirror with NBD instead.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Hi Kevin and Stefan
Can we change the iotest output to fix this?
https://gitlab.com/juan.quintela/qemu/-/jobs/5314070229
tput mismatch (see
/builds/juan.quintela/qemu/build/tests/qemu-iotests/scratch/raw-file-183/183.out.bad)
--- /builds/juan.quintela/qemu/tests/qemu-iotests/183.out
+++
/builds/juan.quintela/qemu/build/tests/qemu-iotests/scratch/raw-file-183/183.out.bad
@@ -28,6 +28,8 @@
{ 'execute': 'migrate',
'arguments': { 'uri': 'unix:SOCK_DIR/migrate', 'blk': true } }
+warning: parameter 'blk is deprecated; use blockdev-mirror with NBD instead
+warning: block migration is deprecated; use blockdev-mirror with NBD instead
{"return": {}}
{ 'execute': 'query-status' }
{"return": {"status": "postmigrate", "singlestep": false, "running":
false}}
I really want to give the warnings two users.
I guess that you want to test blk migration.
What do you recommend?
Later, Juan.
- [PATCH v6 0/5] Migration deprecated parts, Juan Quintela, 2023/10/17
- [PATCH v6 1/5] migration: Print block status when needed, Juan Quintela, 2023/10/17
- [PATCH v6 4/5] migration: Deprecate block migration, Juan Quintela, 2023/10/17
- [PATCH v6 5/5] migration: Deprecate old compression method, Juan Quintela, 2023/10/17
- [PATCH v6 3/5] migration: migrate 'blk' command option is deprecated., Juan Quintela, 2023/10/17
- Re: [PATCH v6 3/5] migration: migrate 'blk' command option is deprecated.,
Juan Quintela <=
- [PATCH v6 2/5] migration: migrate 'inc' command option is deprecated., Juan Quintela, 2023/10/17