Re: [PULL 00/38] Migration 20231016 patches

[Stefan Hajnoczi]

On Mon, 16 Oct 2023 at 13:13, Fabiano Rosas <farosas@suse.de> wrote:
>
> Stefan Hajnoczi <stefanha@gmail.com> writes:
>
> > On Mon, 16 Oct 2023 at 06:11, Juan Quintela <quintela@redhat.com> wrote:
> >>
> >> The following changes since commit 
> >> 63011373ad22c794a013da69663c03f1297a5c56:
> >>
> >>   Merge tag 'pull-riscv-to-apply-20231012-1' of 
> >> https://github.com/alistair23/qemu into staging (2023-10-12 10:24:44 -0400)
> >>
> >> are available in the Git repository at:
> >>
> >>   https://gitlab.com/juan.quintela/qemu.git 
> >> tags/migration-20231016-pull-request
> >>
> >> for you to fetch changes up to f39b0f42753635b0f2d8b00a26d11bb197bf51e2:
> >>
> >>   migration/multifd: Clarify Error usage in multifd_channel_connect 
> >> (2023-10-16 11:01:33 +0200)
> >>
> >> ----------------------------------------------------------------
> >> Migration Pull request (20231016)
> >>
> >> In this pull request:
> >> - rdma cleanups
> >> - removal of QEMUFileHook
> >> - test for analyze-migration.py
> >> - test for multifd file
> >> - multifd cleanups
> >> - available switchover bandwidth
> >> - lots of cleanups.
> >>
> >> CI: https://gitlab.com/juan.quintela/qemu/-/pipelines/1037878829
> >>
> >> Please, apply.
> >
> > This CI failure looks migration-related:
> >
> > MALLOC_PERTURB_=96
> > PYTHON=/home/gitlab-runner/builds/-LCfcJ2T/0/qemu-project/qemu/build/pyvenv/bin/python3
> > QTEST_QEMU_BINARY=./qemu-system-i386
> > G_TEST_DBUS_DAEMON=/home/gitlab-runner/builds/-LCfcJ2T/0/qemu-project/qemu/tests/dbus-vmstate-daemon.sh
> > QTEST_QEMU_IMG=./qemu-img
> > QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon
> > /home/gitlab-runner/builds/-LCfcJ2T/0/qemu-project/qemu/build/tests/qtest/migration-test
> > --tap -k
> > ――――――――――――――――――――――――――――――――――――― ✀ 
> > ―――――――――――――――――――――――――――――――――――――
> > stderr:
> > **
> > ERROR:../tests/qtest/migration-test.c:1969:file_offset_finish_hook:
> > assertion failed (cpu_to_be32(*p) == QEMU_VM_FILE_MAGIC): (3 ==
> > 1363498573)
>
> That's the test for the file: transport which got merged in the last
> PR. I'll look into it.

I have dropped the 20231016 pull request for now and the tests passed
without it. Maybe there is an interaction with the test you recently
added and this pull request?

Stefan