Re: [PATCH] migration: Use g_autofree to simplify ram_dirty_bitmap_reload()

[Philippe Mathieu-Daudé]

On 9/10/23 17:07, Fabiano Rosas wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> > Based-on: <ZR7e3cmxCH9LAdnS@x1n>
> > ---
> >   migration/ram.c | 15 ++++++---------
> >   1 file changed, 6 insertions(+), 9 deletions(-)
> >
> > diff --git a/migration/ram.c b/migration/ram.c
> > index 982fbbeee1..4cb948cfd0 100644
> > --- a/migration/ram.c
> > +++ b/migration/ram.c
> > @@ -4164,11 +4164,11 @@ bool ram_dirty_bitmap_reload(MigrationState *s, 
> > RAMBlock *block, Error **errp)
> >   {
> >       /* from_dst_file is always valid because we're within rp_thread */
> >       QEMUFile *file = s->rp_state.from_dst_file;
> > -    unsigned long *le_bitmap, nbits = block->used_length >> TARGET_PAGE_BITS;
> > +    unsigned long *le_bitmap = NULL;
>
> Aren't you missing the actual g_autofree here?

Argh 🤦🏻 sorry...