Re: [PATCH v2 4/5] hw/intc/apic: Rename x86_cpu_apic_create() -> x86_cpu_apic_new()

[Paolo Bonzini]

On 10/3/23 10:27, Philippe Mathieu-Daudé wrote:
> -        x86_cpu_apic_create(cpu, &local_err);
> -        if (local_err != NULL) {
> -            goto out;
> -        }
> +        x86_cpu_apic_new(cpu);

I don't like this, "*_new" is generally for functions that return what 
they create.

Patch 2 is scary with the newly-introduced possible failure, but I 
suppose it's safer if you reason that any problem will occur at startup, 
not at hotplug time for example.

Paolo