Re: [PATCH v3 10/10] tests/migration-test: Add a test for postcopy hangs during RECOVER

[Peter Xu]

On Thu, Oct 05, 2023 at 10:37:56AM -0300, Fabiano Rosas wrote:
> >> +    /*
> >> +     * Make sure both QEMU instances will go into RECOVER stage, then test
> >> +     * kicking them out using migrate-pause.
> >> +     */
> >> +    wait_for_postcopy_status(from, "postcopy-recover");
> >> +    wait_for_postcopy_status(to, "postcopy-recover");
> >
> > Is this wait out of place? I think we're trying to resume too fast after
> > migrate_recover():
> >
> > # {
> > #     "error": {
> > #         "class": "GenericError",
> > #         "desc": "Cannot resume if there is no paused migration"
> > #     }
> > # }
> >
> 
> Ugh, sorry about the long lines:
> 
> {
>     "error": {
>         "class": "GenericError",
>         "desc": "Cannot resume if there is no paused migration"
>     }
> }

Sorry I didn't get you here.  Could you elaborate your question?

Here we wait on both sides and make sure they'll all be in RECOVER stage,
and we should know that they won't proceed further because the pipes
contain mostly nothing so they'll just block at the pipes.  What did I
miss?

Thanks,

-- 
Peter Xu