[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/47] tcg patch queue
From: |
Stefan Hajnoczi |
Subject: |
Re: [PULL 00/47] tcg patch queue |
Date: |
Wed, 4 Oct 2023 12:46:05 -0400 |
On Wed, 4 Oct 2023 at 12:28, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 10/4/23 07:57, Stefan Hajnoczi wrote:
> > This commit breaks the build:
> >
> > ../bsd-user/signal.c:479:19: error: unused variable 'env'
> > [-Werror,-Wunused-variable]
> > CPUArchState *env = cpu_env(cpu);
> > ^
> >
> > https://gitlab.com/qemu-project/qemu/-/jobs/5222693462
> >
> > Please resend the pull request with a fix.
>
> The line number quoted above does not correspond to my source.
> Did you attempt to merge multiple pulls simultaneously?
> There must be a conflict between them.
>
> My guess is Warner's bsd-user PR.
> Please just apply that first and I'll re-roll mine afterward.
Okay. Note that host_signal_handler()'s env local variable looks
unused in your tag:
https://gitlab.com/rth7680/qemu/-/blob/pull-tcg-20231003/bsd-user/signal.c?ref_type=tags#L473
- [PULL 41/47] accel/tcg: Make cpu-exec-common.c a target agnostic unit, (continued)
- [PULL 41/47] accel/tcg: Make cpu-exec-common.c a target agnostic unit, Richard Henderson, 2023/10/03
- [PULL 40/47] accel/tcg: Make icount.o a target agnostic unit, Richard Henderson, 2023/10/03
- [PULL 42/47] tcg: Remove argument to tcg_prologue_init, Richard Henderson, 2023/10/03
- [PULL 43/47] tcg: Split out tcg init functions to tcg/startup.h, Richard Henderson, 2023/10/03
- [PULL 45/47] build: Remove --enable-gprof, Richard Henderson, 2023/10/03
- [PULL 47/47] tcg/loongarch64: Fix buid error, Richard Henderson, 2023/10/03
- [PULL 44/47] linux-user/hppa: Fix struct target_sigcontext layout, Richard Henderson, 2023/10/03
- [PULL 46/47] tests/avocado: Re-enable MIPS Malta tests (GitLab issue #1884 fixed), Richard Henderson, 2023/10/03
- Re: [PULL 00/47] tcg patch queue, Stefan Hajnoczi, 2023/10/04