Re: [PATCH v6 08/19] linux-user: Add gen-vdso tool

[Philippe Mathieu-Daudé]

On 30/9/23 04:15, Richard Henderson wrote:
> This tool will be used for post-processing the linked vdso image,
> turning it into something that is easy to include into elfload.c.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   linux-user/gen-vdso.c          | 223 ++++++++++++++++++++++++
>   linux-user/gen-vdso-elfn.c.inc | 307 +++++++++++++++++++++++++++++++++
>   linux-user/meson.build         |   6 +-
>   3 files changed, 535 insertions(+), 1 deletion(-)
>   create mode 100644 linux-user/gen-vdso.c
>   create mode 100644 linux-user/gen-vdso-elfn.c.inc


> +static void output_reloc(FILE *outf, void *buf, void *loc)
> +{
> +    fprintf(outf, "    0x%08lx,\n", (unsigned long)(loc - buf));

uintptr_t? Otherwise nice!

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> +}