[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 01/19] parallels: Move inactivation code to a separate function
From: |
Alexander Ivanov |
Subject: |
[PATCH 01/19] parallels: Move inactivation code to a separate function |
Date: |
Mon, 2 Oct 2023 10:57:20 +0200 |
We are going to add parallels image extensions storage and need a separate
function for inactivation code.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels.c | 22 ++++++++++++++++------
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index d026ce9e2f..d5b333d5a4 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -1426,18 +1426,27 @@ fail:
return ret;
}
+static int parallels_inactivate(BlockDriverState *bs)
+{
+ BDRVParallelsState *s = bs->opaque;
+ int ret;
+
+ s->header->inuse = 0;
+ parallels_update_header(bs);
+
+ /* errors are ignored, so we might as well pass exact=true */
+ ret = bdrv_truncate(bs->file, s->data_end << BDRV_SECTOR_BITS, true,
+ PREALLOC_MODE_OFF, 0, NULL);
+
+ return ret;
+}
static void parallels_close(BlockDriverState *bs)
{
BDRVParallelsState *s = bs->opaque;
if ((bs->open_flags & BDRV_O_RDWR) && !(bs->open_flags & BDRV_O_INACTIVE))
{
- s->header->inuse = 0;
- parallels_update_header(bs);
-
- /* errors are ignored, so we might as well pass exact=true */
- bdrv_truncate(bs->file, s->data_end << BDRV_SECTOR_BITS, true,
- PREALLOC_MODE_OFF, 0, NULL);
+ parallels_inactivate(bs);
}
parallels_free_used_bitmap(bs);
@@ -1477,6 +1486,7 @@ static BlockDriver bdrv_parallels = {
.bdrv_co_check = parallels_co_check,
.bdrv_co_pdiscard = parallels_co_pdiscard,
.bdrv_co_pwrite_zeroes = parallels_co_pwrite_zeroes,
+ .bdrv_inactivate = parallels_inactivate,
};
static void bdrv_parallels_init(void)
--
2.34.1
- [PATCH 00/19] parallels: Add full dirty bitmap support, Alexander Ivanov, 2023/10/02
- [PATCH 03/19] parallels: Move host clusters allocation to a separate function, Alexander Ivanov, 2023/10/02
- [PATCH 02/19] parallels: Add mark_unused() helper, Alexander Ivanov, 2023/10/02
- [PATCH 09/19] parallels: Add dirty bitmaps saving, Alexander Ivanov, 2023/10/02
- [PATCH 05/19] parallels: Recreate used bitmap in parallels_check_leak(), Alexander Ivanov, 2023/10/02
- [PATCH 01/19] parallels: Move inactivation code to a separate function,
Alexander Ivanov <=
- [PATCH 17/19] tests: Add parallels images support to test 165, Alexander Ivanov, 2023/10/02
- [PATCH 06/19] parallels: Add a note about used bitmap in parallels_check_duplicate(), Alexander Ivanov, 2023/10/02
- [PATCH 11/19] parallels: Handle L1 entries equal to one, Alexander Ivanov, 2023/10/02
- [PATCH 18/19] tests: Turned on 256, 299, 304 and block-status-cache for parallels format, Alexander Ivanov, 2023/10/02
- [PATCH 04/19] parallels: Set data_end value in parallels_check_leak(), Alexander Ivanov, 2023/10/02
- [PATCH 08/19] parallels: Make mark_used() and mark_unused() global functions, Alexander Ivanov, 2023/10/02
- [PATCH 07/19] parallels: Create used bitmap even if checks needed, Alexander Ivanov, 2023/10/02
- [PATCH 12/19] parallels: Make a loaded dirty bitmap persistent, Alexander Ivanov, 2023/10/02
- [PATCH 13/19] parallels: Reverse a conditional in parallels_check_leak() to reduce indents, Alexander Ivanov, 2023/10/02
- [PATCH 10/19] parallels: Let image extensions work in RW mode, Alexander Ivanov, 2023/10/02