|
| From: | Vladimir Sementsov-Ogievskiy |
| Subject: | Re: [PATCH v7 07/12] nbd/client: Initial support for extended headers |
| Date: | Fri, 29 Sep 2023 12:24:59 +0300 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 |
On 25.09.23 22:22, Eric Blake wrote:
nbd_receive_simple_reply(int32_t error, const char *errname, uint64_t cookie) "Got simple reply: {
.error = %" PRId32 " (%s), cookie = %" PRIu64" }"
-nbd_receive_structured_reply_chunk(uint16_t flags, uint16_t type, const char *name, uint64_t cookie, uint32_t length)
"Got structured reply chunk: { flags = 0x%" PRIx16 ", type = %d (%s), cookie = %" PRIu64 ",
length = %" PRIu32 " }"
+nbd_receive_reply_chunk_header(uint16_t flags, uint16_t type, const char *name, uint64_t cookie, uint32_t length)
"Got reply chunk header: { flags = 0x%" PRIx16 ", type = %d (%s), cookie = %" PRIu64 ", length
= %" PRIu32 " }"
preexisting, but better would be s/%d/%" PRIu16 "/
+nbd_receive_wrong_header(uint32_t magic, const char *mode) "Server sent unexpected magic 0x%" PRIx32 " for negotiated mode %s"
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> -- Best regards, Vladimir
| [Prev in Thread] | Current Thread | [Next in Thread] |