Re: [PATCH 10/11] accel/tcg: Make icount.o a target agnostic unit

[Anton Johansson]

On 15/09/23, Philippe Mathieu-Daudé wrote:
> On 15/9/23 16:31, Anton Johansson wrote:
> > On 14/09/23, Philippe Mathieu-Daudé wrote:
> > > Remove the unused "exec/exec-all.h" header. There is
> > > no more target specific code in it: make it target
> > > agnostic (rename using the '-common' suffix). Since
> > > it is TCG specific, move it to accel/tcg, updating
> > > MAINTAINERS.
> > > 
> > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > > ---
> > >   MAINTAINERS                                   | 1 -
> > >   softmmu/icount.c => accel/tcg/icount-common.c | 3 +--
> > >   accel/tcg/meson.build                         | 1 +
> > >   softmmu/meson.build                           | 4 ----
> > >   4 files changed, 2 insertions(+), 7 deletions(-)
> > >   rename softmmu/icount.c => accel/tcg/icount-common.c (99%)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index ff436dbf21..047d143b9d 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -2912,7 +2912,6 @@ F: softmmu/main.c
> > >   F: softmmu/cpus.c
> > >   F: softmmu/cpu-throttle.c
> > >   F: softmmu/cpu-timers.c
> > > -F: softmmu/icount.c
> > Would also be a maintainer switch
> 
> OK, now I understood your comment. I should have mentioned
> it in the commit description. This move from "Main loop"
> to "Overall TCG". Icount is a TCG feature.
> (Less work for Paolo, but more for Richard...)
Ah that makes sense, just wanted to make sure:)