[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 22/24] accel/tcg: Remove env_tlb()
From: |
Richard Henderson |
Subject: |
[PATCH v2 22/24] accel/tcg: Remove env_tlb() |
Date: |
Wed, 13 Sep 2023 19:44:33 -0700 |
From: Anton Johansson <anjo@rev.ng>
The function is no longer used to access the TLB,
and has been replaced by cpu->neg.tlb.
Signed-off-by: Anton Johansson <anjo@rev.ng>
Message-Id: <20230912153428.17816-9-anjo@rev.ng>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
[rth: Merge comment update patch]
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/exec/cpu-all.h | 11 -----------
tcg/aarch64/tcg-target.c.inc | 2 +-
tcg/arm/tcg-target.c.inc | 2 +-
3 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
index af9516654a..b37715c27d 100644
--- a/include/exec/cpu-all.h
+++ b/include/exec/cpu-all.h
@@ -451,15 +451,4 @@ static inline CPUState *env_cpu(CPUArchState *env)
return (void *)env - sizeof(CPUState);
}
-/**
- * env_tlb(env)
- * @env: The architecture environment
- *
- * Return the CPUTLB state associated with the environment.
- */
-static inline CPUTLB *env_tlb(CPUArchState *env)
-{
- return &env_cpu(env)->neg.tlb;
-}
-
#endif /* CPU_ALL_H */
diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc
index 0931a69448..0db4c907e3 100644
--- a/tcg/aarch64/tcg-target.c.inc
+++ b/tcg/aarch64/tcg-target.c.inc
@@ -1676,7 +1676,7 @@ static TCGLabelQemuLdst *prepare_host_addr(TCGContext *s,
HostAddress *h,
mask_type = (s->page_bits + s->tlb_dyn_max_bits > 32
? TCG_TYPE_I64 : TCG_TYPE_I32);
- /* Load env_tlb(env)->f[mmu_idx].{mask,table} into {tmp0,tmp1}. */
+ /* Load cpu->neg.tlb.f[mmu_idx].{mask,table} into {tmp0,tmp1}. */
QEMU_BUILD_BUG_ON(offsetof(CPUTLBDescFast, mask) != 0);
QEMU_BUILD_BUG_ON(offsetof(CPUTLBDescFast, table) != 8);
tcg_out_insn(s, 3314, LDP, TCG_REG_TMP0, TCG_REG_TMP1, TCG_AREG0,
diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc
index acb5f23b54..75978018c9 100644
--- a/tcg/arm/tcg-target.c.inc
+++ b/tcg/arm/tcg-target.c.inc
@@ -1420,7 +1420,7 @@ static TCGLabelQemuLdst *prepare_host_addr(TCGContext *s,
HostAddress *h,
ldst->addrlo_reg = addrlo;
ldst->addrhi_reg = addrhi;
- /* Load env_tlb(env)->f[mmu_idx].{mask,table} into {r0,r1}. */
+ /* Load cpu->neg.tlb.f[mmu_idx].{mask,table} into {r0,r1}. */
QEMU_BUILD_BUG_ON(offsetof(CPUTLBDescFast, mask) != 0);
QEMU_BUILD_BUG_ON(offsetof(CPUTLBDescFast, table) != 4);
tcg_out_ldrd_8(s, COND_AL, TCG_REG_R0, TCG_AREG0, fast_off);
--
2.34.1
- [PATCH v2 12/24] tcg: Rename cpu_env to tcg_env, (continued)
- [PATCH v2 12/24] tcg: Rename cpu_env to tcg_env, Richard Henderson, 2023/09/13
- [PATCH v2 17/24] accel/tcg: Modify tlb_*() to use CPUState, Richard Henderson, 2023/09/13
- [PATCH v2 14/24] accel/tcg: Remove cpu_set_cpustate_pointers, Richard Henderson, 2023/09/13
- [PATCH v2 18/24] accel/tcg: Modify probe_access_internal() to use CPUState, Richard Henderson, 2023/09/13
- [PATCH v2 19/24] accel/tcg: Modifies memory access functions to use CPUState, Richard Henderson, 2023/09/13
- [PATCH v2 22/24] accel/tcg: Remove env_tlb(),
Richard Henderson <=
- [PATCH v2 20/24] accel/tcg: Modify atomic_mmu_lookup() to use CPUState, Richard Henderson, 2023/09/13
- [PATCH v2 16/24] tcg: Remove TCGContext.tlb_fast_offset, Richard Henderson, 2023/09/13
- [PATCH v2 15/24] accel/tcg: Remove env_neg(), Richard Henderson, 2023/09/13
- [PATCH v2 21/24] accel/tcg: Use CPUState in atomicity helpers, Richard Henderson, 2023/09/13