qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] iotests: improve 'not run' message for nbd-multiconn tes


From: Eric Blake
Subject: Re: [PATCH 2/3] iotests: improve 'not run' message for nbd-multiconn test
Date: Wed, 13 Sep 2023 10:09:12 -0500
User-agent: NeoMutt/20230517

On Wed, Sep 06, 2023 at 04:09:16PM +0200, Denis V. Lunev wrote:
> The test actually requires Python bindings to libnbd rather than libnbd
> itself. Clarify that inside the message.

Makes sense; distros have the freedom to break the upstream monolithic
libnbd project into smaller distribution packages for minimizing
dependencies for different functionalities.

> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Kevin Wolf <kwolf@redhat.com>
> CC: Hanna Reitz <hreitz@redhat.com>
> CC: Eric Blake <eblake@redhat.com>
> CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>  tests/qemu-iotests/tests/nbd-multiconn | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/tests/qemu-iotests/tests/nbd-multiconn 
> b/tests/qemu-iotests/tests/nbd-multiconn
> index b121f2e363..478a1eaba2 100755
> --- a/tests/qemu-iotests/tests/nbd-multiconn
> +++ b/tests/qemu-iotests/tests/nbd-multiconn
> @@ -142,4 +142,4 @@ if __name__ == '__main__':
>  
>          iotests.main(supported_fmts=['qcow2'])
>      except ImportError:
> -        iotests.notrun('libnbd not installed')
> +        iotests.notrun('Python bindings to libnbd are not installed')
> -- 
> 2.34.1
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]