Re: [PATCH 0/1] qom: fix setting of qdev array properties

[Markus Armbruster]

Kevin Wolf <kwolf@redhat.com> writes:

> Am 07.09.2023 um 11:33 hat Markus Armbruster geschrieben:
>> Kevin Wolf <kwolf@redhat.com> writes:
>> > Am 04.09.2023 um 18:25 hat Daniel P. Berrangé geschrieben:
>> >> I still think for user creatable devices we'd be better off just
>> >> mandating the use of JSON syntax for -device and thus leveraging
>> >> the native JSON array type. This patch was the quick fix for the
>> >> existing array property syntax though.
>> >
>> > I agree, let's not apply this one. It puts another ugly hack in the
>> > common QOM code path just to bring back the old ugly hack in qdev.
>> 
>> Since -device supports both JSON and dotted keys, we'd still offer a
>> (differently ugly) solution for users averse to JSON.
>
> I'm afraid this is not true until we actually QAPIfy -device and change
> the non-JSON path to the keyval parser. At the moment, it still uses
> qemu_opts_parse_noisily(), so no dotted key syntax.

You're right; we chickened out of switching the parser, and I suppressed
the memory.