Re: [PATCH 13/32] hw/sd: Introduce a "sd-card" SPI variant model

[Philippe Mathieu-Daudé]

On 3/7/23 15:24, Cédric Le Goater wrote:
> and replace the SDState::spi attribute with a test checking the
> SDProto array of commands.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   include/hw/sd/sd.h  |  3 +++
>   hw/arm/stellaris.c  |  3 +--
>   hw/riscv/sifive_u.c |  3 +--
>   hw/sd/sd.c          | 52 +++++++++++++++++++++++++++++++++------------
>   4 files changed, 43 insertions(+), 18 deletions(-)
I'd rather TYPE_SD_CARD_SPI have a SSI parent bus, having
the realize() method create an internal TYPE_SSI_SD
SD <-> SPI bus bridge, and attaching the SD card on it.
Then we could even make TYPE_SSI_SD private.

Anyway, "can be done later" and "good enough for now"
I suppose, so:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thanks!