[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 8/8] migration: Add a wrapper to cleanup migration files
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH v4 8/8] migration: Add a wrapper to cleanup migration files |
|
Date: |
Wed, 16 Aug 2023 17:55:49 -0400 |
On Wed, Aug 16, 2023 at 06:20:58PM -0300, Fabiano Rosas wrote:
> > One more thing to mention is, now I kind of agree probably we should
> > register yank over each qemufile, as you raised the concern in the other
> > thread that otherwise qmp_yank() won't set error for the qemufile, which
> > seems to be unexpected.
>
> I haven't made up my mind yet, but I think I'd rather stop setting that
> error instead of doing it from other places. A shutdown() is mostly a
> benign operation intended to end the connection. The fact that we use it
> in some cases to kick the thread out of a possible hang doesn't seem
> compelling enough to set -EIO.
>
> Of course we currently have no other way to indicate that the file was
> shutdown, so the -EIO will have to stay and that's a discussion for
> another day.
Yes, if we can avoid setting -EIO at all when shutdown that'll also be
good, maybe making more sense. Thanks,
--
Peter Xu
- [PATCH v4 2/8] migration: Fix possible races when shutting down the return path, (continued)
- [PATCH v4 2/8] migration: Fix possible races when shutting down the return path, Fabiano Rosas, 2023/08/16
- [PATCH v4 5/8] migration: Consolidate return path closing code, Fabiano Rosas, 2023/08/16
- [PATCH v4 4/8] migration: Remove redundant cleanup of postcopy_qemufile_src, Fabiano Rosas, 2023/08/16
- [PATCH v4 6/8] migration: Replace the return path retry logic, Fabiano Rosas, 2023/08/16
- [PATCH v4 7/8] migration: Move return path cleanup to main migration thread, Fabiano Rosas, 2023/08/16
- [PATCH v4 8/8] migration: Add a wrapper to cleanup migration files, Fabiano Rosas, 2023/08/16