[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-8.1 v10 11/14] linux-user: Remove duplicate CPU_LOG_PAGE from
From: |
Richard Henderson |
Subject: |
[PATCH for-8.1 v10 11/14] linux-user: Remove duplicate CPU_LOG_PAGE from probe_guest_base |
Date: |
Mon, 7 Aug 2023 09:37:02 -0700 |
The proper logging for probe_guest_base is in the main function.
There is no need to duplicate that in the subroutines.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/elfload.c | 19 -------------------
1 file changed, 19 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index f497286abe..400af4a4c0 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -2562,9 +2562,6 @@ static void pgb_have_guest_base(const char *image_name,
abi_ulong guest_loaddr,
if (test != addr) {
pgb_fail_in_use(image_name);
}
- qemu_log_mask(CPU_LOG_PAGE,
- "%s: base @ %p for %" PRIu64 " bytes\n",
- __func__, addr, (uint64_t)guest_hiaddr - guest_loaddr + 1);
}
/**
@@ -2607,9 +2604,6 @@ static uintptr_t pgd_find_hole_fallback(uintptr_t
guest_size, uintptr_t brk,
if (mmap_start != MAP_FAILED) {
munmap(mmap_start, guest_size);
if (mmap_start == (void *) align_start) {
- qemu_log_mask(CPU_LOG_PAGE,
- "%s: base @ %p for %" PRIdPTR" bytes\n",
- __func__, mmap_start + offset, guest_size);
return (uintptr_t) mmap_start + offset;
}
}
@@ -2691,13 +2685,6 @@ static uintptr_t pgb_find_hole(uintptr_t guest_loaddr,
uintptr_t guest_size,
}
}
free_self_maps(maps);
-
- if (ret != -1) {
- qemu_log_mask(CPU_LOG_PAGE, "%s: base @ %" PRIxPTR
- " for %" PRIuPTR " bytes\n",
- __func__, ret, guest_size);
- }
-
return ret;
}
@@ -2749,9 +2736,6 @@ static void pgb_static(const char *image_name, abi_ulong
orig_loaddr,
}
guest_base = addr;
-
- qemu_log_mask(CPU_LOG_PAGE, "%s: base @ %"PRIxPTR" for %" PRIuPTR"
bytes\n",
- __func__, addr, hiaddr - loaddr);
}
static void pgb_dynamic(const char *image_name, long align)
@@ -2809,9 +2793,6 @@ static void pgb_reserved_va(const char *image_name,
abi_ulong guest_loaddr,
reserved_va + 1, test, strerror(errno));
exit(EXIT_FAILURE);
}
-
- qemu_log_mask(CPU_LOG_PAGE, "%s: base @ %p for %lu bytes\n",
- __func__, addr, reserved_va + 1);
}
void probe_guest_base(const char *image_name, abi_ulong guest_loaddr,
--
2.34.1
- Re: [PATCH for-8.1 v10 08/14] linux-user: Do not adjust zero_bss for host page size, (continued)
[PATCH for-8.1 v10 03/14] linux-user: Define ELF_ET_DYN_BASE in $guest/target_mman.h, Richard Henderson, 2023/08/07
[PATCH for-8.1 v10 09/14] linux-user: Use zero_bss for PT_LOAD with no file contents too, Richard Henderson, 2023/08/07
[PATCH for-8.1 v10 11/14] linux-user: Remove duplicate CPU_LOG_PAGE from probe_guest_base,
Richard Henderson <=
[PATCH for-8.1 v10 13/14] linux-user: Rewrite fixed probe_guest_base, Richard Henderson, 2023/08/07
[PATCH for-8.1 v10 12/14] linux-user: Consolidate guest bounds check in probe_guest_base, Richard Henderson, 2023/08/07
[PATCH for-8.1 v10 14/14] linux-user: Rewrite non-fixed probe_guest_base, Richard Henderson, 2023/08/07
[PATCH for-8.1 v10 02/14] linux-user: Define TASK_UNMAPPED_BASE in $guest/target_mman.h, Richard Henderson, 2023/08/07
Re: [PATCH for-8.1 v10 00/14] linux-user: image mapping fixes, Alex Bennée, 2023/08/08