[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Stable-7.2.5 26/36] target/m68k: Fix semihost lseek offset computation
From: |
Michael Tokarev |
Subject: |
[Stable-7.2.5 26/36] target/m68k: Fix semihost lseek offset computation |
Date: |
Fri, 4 Aug 2023 21:53:39 +0300 |
From: Peter Maydell <peter.maydell@linaro.org>
The arguments for deposit64 are (value, start, length, fieldval); this
appears to have thought they were (value, fieldval, start,
length). Reorder the parameters to match the actual function.
Cc: qemu-stable@nongnu.org
Fixes: 950272506d ("target/m68k: Use semihosting/syscalls.h")
Reported-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230801154519.3505531-1-peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
(cherry picked from commit 8caaae7319a5f7ca449900c0e6bfcaed78fa3ae2)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c
index 87b1314925..7a88205ce7 100644
--- a/target/m68k/m68k-semi.c
+++ b/target/m68k/m68k-semi.c
@@ -165,7 +165,7 @@ void do_m68k_semihosting(CPUM68KState *env, int nr)
GET_ARG64(2);
GET_ARG64(3);
semihost_sys_lseek(cs, m68k_semi_u64_cb, arg0,
- deposit64(arg2, arg1, 32, 32), arg3);
+ deposit64(arg2, 32, 32, arg1), arg3);
break;
case HOSTED_RENAME:
--
2.39.2
- [PATCH v3 0/7] aspeed: Add blockdev support for flash device definition, Cédric Le Goater, 2023/08/31
- [PATCH v3 3/7] aspeed/smc: Wire CS lines at reset, Cédric Le Goater, 2023/08/31
- [PATCH v3 2/7] hw/ssi: Introduce a ssi_get_cs() helper, Cédric Le Goater, 2023/08/31
- [PATCH v3 1/7] hw/ssi: Add a "cs" property to SSIPeripheral, Cédric Le Goater, 2023/08/31
- [PATCH v3 4/7] hw/ssi: Check for duplicate CS indexes, Cédric Le Goater, 2023/08/31
- [PATCH v3 5/7] aspeed: Create flash devices only when defaults are enabled, Cédric Le Goater, 2023/08/31
- [PATCH v3 7/7] aspeed: Get the BlockBackend of FMC0 from the flash device, Cédric Le Goater, 2023/08/31
- [PATCH v3 6/7] m25p80: Introduce an helper to retrieve the BlockBackend of a device, Cédric Le Goater, 2023/08/31