Re: [PATCH 11/21] swim: add trace events for IWM and ISM registers

[Mark Cave-Ayland]

On 03/07/2023 09:26, Philippe Mathieu-Daudé wrote:

> On 2/7/23 17:48, Mark Cave-Ayland wrote:
> > Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> > ---
> >   hw/block/swim.c       | 14 ++++++++++++++
> >   hw/block/trace-events |  7 +++++++
> >   2 files changed, 21 insertions(+)
>
>
> > @@ -267,6 +275,7 @@ static void iwmctrl_write(void *opaque, hwaddr reg, uint64_t 
> > value,
> >       reg >>= REG_SHIFT;
> >       swimctrl->regs[reg >> 1] = reg & 1;
> > +    trace_swim_iwmctrl_write((reg >> 1), size, (reg & 1));
> >       if (swimctrl->regs[IWM_Q6] &&
> >           swimctrl->regs[IWM_Q7]) {
> > @@ -297,6 +306,7 @@ static void iwmctrl_write(void *opaque, hwaddr reg, uint64_t 
> > value,
> >                   if (value == 0x57) {
> >                       swimctrl->mode = SWIM_MODE_SWIM;
> >                       swimctrl->iwm_switch = 0;
> > +                    trace_swim_iwm_switch();
> >                   }
> >                   break;
> >               }
> > @@ -312,6 +322,7 @@ static uint64_t iwmctrl_read(void *opaque, hwaddr reg, unsigned 
> > size)
> >       swimctrl->regs[reg >> 1] = reg & 1;
> > +    trace_swim_iwmctrl_read((reg >> 1), size, (reg & 1));
> >       return 0;
> >   }
>
>
> > +swim_swimctrl_read(int reg, const char *name, unsigned size, uint64_t value) 
> > "reg=%d [%s] size=%u value=0x%"PRIx64
> > +swim_swimctrl_write(int reg, const char *name, unsigned size, uint64_t value) 
> > "reg=%d [%s] size=%u value=0x%"PRIx64
> > +swim_iwmctrl_read(int reg, unsigned size, uint64_t value) "reg=%d size=%u 
> > value=0x%"PRIx64
> > +swim_iwmctrl_write(int reg, unsigned size, uint64_t value) "reg=%d size=%u 
> > value=0x%"PRIx64
>
> For these 2 functions, 'value' is 1 bit so could be 'unsigned' ;)

Indeed. In fact I'd be inclined to make them "unsigned int" just to be sure there is 
no confusion :)

> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>


ATB,

Mark.