Re: [PATCH 08/11] hw/virtio/virtio-iommu: Use target-agnostic qemu_target_page_mask()

[Philippe Mathieu-Daudé]

On 24/5/23 01:28, Richard Henderson wrote:
> On 5/23/23 09:35, Philippe Mathieu-Daudé wrote:
> > In order to have virtio-iommu.c become target-agnostic,
> > we need to avoid using TARGET_PAGE_MASK. Get it with the
> > qemu_target_page_mask() helper.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   hw/virtio/virtio-iommu.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)


> > @@ -1164,7 +1165,7 @@ static void 
> > virtio_iommu_device_realize(DeviceState *dev, Error **errp)
> >        * in vfio realize
> >        */
> >       s->config.bypass = s->boot_bypass;
> > -    s->config.page_size_mask = TARGET_PAGE_MASK;
> > +    s->config.page_size_mask = qemu_target_page_mask();
>
> This could be
>
>    = -(uint64_t)qemu_target_page_size()
>
> without adding the new function.

Alex recommended on IRC to add a helper "by all means" :)

> But either way,
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Thanks!