Re: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

[Peter Xu]

On Tue, May 23, 2023 at 02:30:25PM +0000, Wang, Wei W wrote:
> > It's about whether we want to protect e.g. below steps:
> > 
> > 1. start dest qemu with -incoming defer
> > 2. "migrate-set-capabilities" to enable multifd
> > 3. "migrate-incoming xxx" to setup the sockets
> > 4. "migrate-set-parameters" to setup the num of multifd   <--- will be 
> > invalid here
> 
> Yes, step 4 is invalid, but I think nobody cares about that (i.e. no place 
> uses the
> invalid value) as step2 already fails the cap setting (with error messages).

Since only until step 3 it setups the transport_data, so step 2 should be
fine and not fail?  That's the whole point of my example or I missd
something here..

-- 
Peter Xu