[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 7/9] linux-user: Don't require PROT_READ for mincore
From: |
Laurent Vivier |
Subject: |
[PULL 7/9] linux-user: Don't require PROT_READ for mincore |
Date: |
Wed, 17 May 2023 10:01:50 +0200 |
From: Thomas Weißschuh <thomas@t-8ch.de>
The kernel does not require PROT_READ for addresses passed to mincore.
For example the fincore(1) tool from util-linux uses PROT_NONE and
currently does not work under qemu-user.
Example (with fincore(1) from util-linux 2.38):
$ fincore /proc/self/exe
RES PAGES SIZE FILE
24K 6 22.1K /proc/self/exe
$ qemu-x86_64 /usr/bin/fincore /proc/self/exe
fincore: failed to do mincore: /proc/self/exe: Cannot allocate memory
With this patch:
$ ./build/qemu-x86_64 /usr/bin/fincore /proc/self/exe
RES PAGES SIZE FILE
24K 6 22.1K /proc/self/exe
Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20230422100314.1650-3-thomas@t-8ch.de>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
linux-user/syscall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 00a779797efb..6655982821ba 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -11993,7 +11993,7 @@ static abi_long do_syscall1(CPUArchState *cpu_env, int
num, abi_long arg1,
#ifdef TARGET_NR_mincore
case TARGET_NR_mincore:
{
- void *a = lock_user(VERIFY_READ, arg1, arg2, 0);
+ void *a = lock_user(VERIFY_NONE, arg1, arg2, 0);
if (!a) {
return -TARGET_ENOMEM;
}
--
2.40.1
- [PULL 2/9] linux-user: report ENOTTY for unknown ioctls, (continued)
- [PULL 2/9] linux-user: report ENOTTY for unknown ioctls, Laurent Vivier, 2023/05/16
- [PULL 9/9] linux-user: fix getgroups/setgroups allocations, Laurent Vivier, 2023/05/16
- [PULL 8/9] linux-user: Fix mips fp64 executables loading, Laurent Vivier, 2023/05/16
- [PULL 5/9] linux-user/main: Use list_cpus() instead of cpu_list(), Laurent Vivier, 2023/05/16
- [PULL 7/9] linux-user: Don't require PROT_READ for mincore, Laurent Vivier, 2023/05/16
- [PULL 1/9] linux-user: Emulate /proc/cpuinfo output for riscv, Laurent Vivier, 2023/05/16
- Re: [PULL 0/9] Linux user for 8.1 patches, Richard Henderson, 2023/05/16
- [PULL 0/9] Linux user for 8.1 patches, Laurent Vivier, 2023/05/17
- [PULL 2/9] linux-user: report ENOTTY for unknown ioctls, Laurent Vivier, 2023/05/17
- [PULL 7/9] linux-user: Don't require PROT_READ for mincore,
Laurent Vivier <=
- [PULL 9/9] linux-user: fix getgroups/setgroups allocations, Laurent Vivier, 2023/05/17
- [PULL 4/9] linux-user: Add open_tree() syscall, Laurent Vivier, 2023/05/17
- [PULL 3/9] linux-user: Add move_mount() syscall, Laurent Vivier, 2023/05/17
- [PULL 5/9] linux-user/main: Use list_cpus() instead of cpu_list(), Laurent Vivier, 2023/05/17
- [PULL 8/9] linux-user: Fix mips fp64 executables loading, Laurent Vivier, 2023/05/17
- [PULL 6/9] linux-user: Add new flag VERIFY_NONE, Laurent Vivier, 2023/05/17
- [PULL 1/9] linux-user: Emulate /proc/cpuinfo output for riscv, Laurent Vivier, 2023/05/17
- Re: [PULL 0/9] Linux user for 8.1 patches, Richard Henderson, 2023/05/17