[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 5/8] migration: converts exec backend to accept MigrateAdd
From: |
Juan Quintela |
Subject: |
Re: [PATCH v4 5/8] migration: converts exec backend to accept MigrateAddress struct. |
Date: |
Mon, 15 May 2023 11:58:33 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Het Gala <het.gala@nutanix.com> wrote:
> Exec transport backend for 'migrate'/'migrate-incoming' QAPIs accept
> new wire protocol of MigrateAddress struct.
>
> It is achived by parsing 'uri' string and storing migration parameters
> required for exec connection into strList struct.
>
> Suggested-by: Aravind Retnakaran <aravind.retnakaran@nutanix.com>
> Signed-off-by: Het Gala <het.gala@nutanix.com>
> ---
> migration/exec.c | 58 ++++++++++++++++++++++++++++++++-----------
> migration/exec.h | 4 +--
> migration/migration.c | 10 +++-----
> 3 files changed, 50 insertions(+), 22 deletions(-)
>
> diff --git a/migration/exec.c b/migration/exec.c
> index c4a3293246..210f4e9400 100644
> --- a/migration/exec.c
> +++ b/migration/exec.c
> @@ -39,22 +39,51 @@ const char *exec_get_cmd_path(void)
> }
> #endif
>
> -void exec_start_outgoing_migration(MigrationState *s, const char *command,
> +/* provides the length of strList */
> +static int
> +str_list_length(strList *list)
> +{
> + int len = 0;
> + strList *elem;
> +
> + for (elem = list; elem != NULL; elem = elem->next) {
> + len++;
> + }
> +
> + return len;
> +}
I can't believe tat we have a list type and we don't have a length()
function for that type.
Sniff.
Reviewed-by: Juan Quintela <quintela@redhat.com>
- Re: [PATCH v4 3/8] migration: converts socket backend to accept MigrateAddress struct, (continued)
[PATCH v4 6/8] migration: modified 'migrate' QAPI to accept 'channels' argument for migration, Het Gala, 2023/05/12
[PATCH v4 5/8] migration: converts exec backend to accept MigrateAddress struct., Het Gala, 2023/05/12
[PATCH v4 4/8] migration: converts rdma backend to accept MigrateAddress struct, Het Gala, 2023/05/12
[PATCH v4 7/8] migration: modified 'migrate-incoming' QAPI to accept 'channels' argument for migration., Het Gala, 2023/05/12