Re: [PULL v3 0/10] xenpvh3-tag

[Vikram Garhwal]

Hi Richard,

On 5/3/23 12:47 AM, Richard Henderson wrote:
> On 5/3/23 01:12, Stefano Stabellini wrote:
> > Hi Peter,
> >
> > Vikram fixed the gitlab test problem, so now all the tests should
> > succeed. There were no changes to the QEMU code. I am resending the pull
> > request (I rebased it on staging, no conflicts.)
> >
> > For reference this was the previous pull request:
> > https://marc.info/?l=qemu-devel&m=167641819725964
> >
> > Cheers,
> >
> > Stefano
> >
> >
> > The following changes since commit 
> > 4ebc33f3f3b656ebf62112daca6aa0f8019b4891:
> >
> >    Merge tag 'pull-tcg-20230502-2' of https://gitlab.com/rth7680/qemu 
> > into staging (2023-05-02 21:18:45 +0100)
> >
> > are available in the Git repository at:
> >
> >    https://gitlab.com/sstabellini/qemu xenpvh3-tag
> >
> > for you to fetch changes up to bc618c54318cbc2fcb9decf9d4c193cc336a0dbc:
> >
> >    meson.build: enable xenpv machine build for ARM (2023-05-02 
> > 17:04:54 -0700)
> >
> > ----------------------------------------------------------------
> > Stefano Stabellini (5):
> >        hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState
> >        xen-hvm: reorganize xen-hvm and move common function to 
> > xen-hvm-common
> >        include/hw/xen/xen_common: return error from 
> > xen_create_ioreq_server
> >        hw/xen/xen-hvm-common: skip ioreq creation on ioreq 
> > registration failure
> >        meson.build: do not set have_xen_pci_passthrough for aarch64 
> > targets
> >
> > Vikram Garhwal (5):
> >        hw/i386/xen/: move xen-mapcache.c to hw/xen/
> >        hw/i386/xen: rearrange xen_hvm_init_pc
> >        hw/xen/xen-hvm-common: Use g_new and error_report
> >        hw/arm: introduce xenpvh machine
> >        meson.build: enable xenpv machine build for ARM
>
> Errors in CI:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/4216392008#L2381
>
> ../hw/i386/xen/xen-hvm.c:303:9: error: implicit declaration of 
> function 'error_report' is invalid in C99 
> [-Werror,-Wimplicit-function-declaration]
>         error_report("relocate_memory %lu pages from GFN %"HWADDR_PRIx
Thanks for notifying this. I am not sure why this particular build is 
failing. error_report() is defined in "|qemu/error-report.h" and the 
header should be included as |||it builds fine for other configs.
|Also, the same tsan-build passed when we sent the PULL for v2.

||||I am not sure why it's failing for this config. W||ill try to fix 
this. Meanwhile, any hints on how to fix/debug this?

Regards,
Vikram
|
> ^
>
>
> r~