Re: [PATCH] linux-user/main: Use list_cpus() instead of cpu_list()

[Laurent Vivier]

Le 24/04/2023 à 14:21, Thomas Huth a écrit :
> This way we can get rid of the if'deffery and the XXX comment
> here (it's repeated in the list_cpus() function anyway).
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   linux-user/main.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index fe03293516..aece4d9e91 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -359,10 +359,7 @@ static void handle_arg_cpu(const char *arg)
>   {
>       cpu_model = strdup(arg);
>       if (cpu_model == NULL || is_help_option(cpu_model)) {
> -        /* XXX: implement xxx_cpu_list for targets that still miss it */
> -#if defined(cpu_list)
> -        cpu_list();
> -#endif
> +        list_cpus();
>           exit(EXIT_FAILURE);
>       }
>   }

Applied to my linux-user-for-8.1 branch.

Thanks,
Laurent