[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 07/11] qapi/gen: run C code through clang-format, if possi
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v4 07/11] qapi/gen: run C code through clang-format, if possible |
|
Date: |
Mon, 6 Mar 2023 16:05:21 +0000 |
On Mon, 6 Mar 2023 at 12:33, <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Make the resulting code even prettier, if possible.
This seems to be a bit short on rationale. This is generated
code, so in general nobody is going to be reading it, and
running clang-format on it every time we generate code feels
like it would be a bit of a waste of cycles...
thanks
-- PMM
- Re: [PATCH v4 04/11] osdep: implement qemu_socketpair() for win32, (continued)
[PATCH v4 05/11] qmp: 'add_client' actually expects sockets, marcandre . lureau, 2023/03/06
[PATCH v4 06/11] monitor: release the lock before calling close(), marcandre . lureau, 2023/03/06
[PATCH v4 07/11] qapi/gen: run C code through clang-format, if possible, marcandre . lureau, 2023/03/06
[PATCH v4 08/11] qmp: add 'get-win32-socket', marcandre . lureau, 2023/03/06
[PATCH v4 11/11] QMP/HMP: only actually implement getfd on CONFIG_POSIX, marcandre . lureau, 2023/03/06
[PATCH v4 09/11] libqtest: make qtest_qmp_add_client work on win32, marcandre . lureau, 2023/03/06