[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/migration: Tweek auto converge limits check
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH] tests/migration: Tweek auto converge limits check |
Date: |
Mon, 6 Mar 2023 15:39:01 +0000 |
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Mon, Mar 06, 2023 at 03:26:12PM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Thomas found an autoconverge test failure where the
> migration completed before the autoconverge had kicked in.
>
> To try and avoid this again:
> a) Reduce the usleep in test_migrate_auto_converge
> so that it should exit quicker when autoconverge kicks in
> b) Make the loop exit immediately rather than have the sleep
> when it does start autoconverge, otherwise the autoconverge
> might succeed during the sleep.
> c) Reduce inc_pct so auto converge happens more slowly
> d) Reduce the max-bandwidth in migrate_ensure_non_converge
> to make the ensure more ensure.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> tests/qtest/migration-test.c | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|