[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 07/10] qapi: implement conditional command arguments
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v3 07/10] qapi: implement conditional command arguments |
|
Date: |
Thu, 2 Mar 2023 09:31:46 +0000 |
|
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Thu, Mar 02, 2023 at 07:58:28AM +0100, Markus Armbruster wrote:
> Marc-André Lureau <marcandre.lureau@gmail.com> writes:
>
> > Hi
> >
> > On Wed, Mar 1, 2023 at 5:16 PM Markus Armbruster <armbru@redhat.com> wrote:
> >> What about 3. have an additional command conditional on CONFIG_WIN32?
> >> Existing getfd stays the same: always fails when QEMU runs on a Windows
> >> host. The new command exists only when QEMU runs on a Windows host.
>
> We could additionally deprecate getfd for Windows.
>
> > This is what was suggested initially:
> > https://patchew.org/QEMU/20230103110814.3726795-1-marcandre.lureau@redhat.com/20230103110814.3726795-9-marcandre.lureau@redhat.com/
> >
> > I also like it better, as a specific command for windows sockets, less
> > ways to use it wrongly.
>
> Daniel, what do you think?
I wasn't especially a fan of platform specific APIs, but perhaps in
retrospect it will be the lesser of two evils.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|