qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC 34/52] i386: Rename variable topo_info to apicid_topo


From: Philippe Mathieu-Daudé
Subject: Re: [RFC 34/52] i386: Rename variable topo_info to apicid_topo
Date: Mon, 13 Feb 2023 14:28:54 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2

On 13/2/23 10:50, Zhao Liu wrote:
From: Zhao Liu <zhao1.liu@intel.com>

Since X86ApicidTopoInfo is only used for APIC ID related work, the
common variable topo_info of X86ApicidTopoInfo type should be also
renamed to better suit its purpose.

Generic topology access should be obtained from MachineState.topo
(for the whole machine) or CPUState.topo (for the current CPU), and
apicid_topo (X86ApicidTopoInfo type) is only used to collaborate with
APIC ID.

Co-Developed-by: Zhuocheng Ding <zhuocheng.ding@intel.com>
Signed-off-by: Zhuocheng Ding <zhuocheng.ding@intel.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
  hw/i386/x86.c                |  38 ++++-----
  include/hw/i386/topology.h   |  76 ++++++++---------
  include/hw/i386/x86.h        |   2 +-
  target/i386/cpu.c            |  71 ++++++++--------
  tests/unit/test-x86-apicid.c | 158 +++++++++++++++++------------------
  5 files changed, 173 insertions(+), 172 deletions(-)

The 'id' suffix doesn't add a lot of value IMO. Anyway,

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]