Re: [PATCH 2/2] linux-user: Show 4th argument of rt_sigprocmask() in strace

[Laurent Vivier]

Le 25/01/2023 à 14:57, Helge Deller a écrit :
> Add output for the missing 4th parameter (size_t sigsetsize).
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
>   linux-user/strace.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index 3157e4b420..e3aa994678 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -3146,7 +3146,8 @@ print_rt_sigprocmask(CPUArchState *cpu_env, const struct 
> syscallname *name,
>       }
>       qemu_log("%s,", how);
>       print_pointer(arg1, 0);
> -    print_pointer(arg2, 1);
> +    print_pointer(arg2, 0);
> +    print_raw_param("%d", arg3, 1);

Better with "%u" as size_t is unsigned.

Thanks,
Laurent
>       print_syscall_epilogue(name);
>   }
>   #endif
> --
> 2.38.1